Fix non-primary channel usage for non-PKC packets #5287
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thebentern
approved these changes
Nov 8, 2024
jp-bennett
approved these changes
Nov 9, 2024
fifieldt
approved these changes
Nov 9, 2024
fifieldt
force-pushed
the
nodeChannelFix
branch
from
e95261f to
02706ab
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Even if we have the public key of a node, for some packets we use the legacy channels (e.g., traceroute, NodeInfo, Routing) and those should use the channel corresponding to a node. In
perhapsEncode(), the channel will be set back to 0 when we do use PKC. Also this clause will still pass if the client explicitly requested PKC:firmware/src/mesh/Router.cpp
Line 497 in 439c1de