Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Exclude some niche modules by default and populate exclude_modules #5300

Merged
merged 4 commits into from
Nov 10, 2024

Conversation

thebentern
Copy link
Contributor

No description provided.

@thebentern thebentern marked this pull request as ready for review November 10, 2024 11:07
@fifieldt
Copy link
Contributor

Needed to fix the failing jobs: #5301

@fifieldt fifieldt force-pushed the exclude-modules-by-default branch from fa00691 to f131102 Compare November 10, 2024 12:01
@thebentern thebentern changed the title Exclude some niche modules by default Exclude some niche modules by default and add to exclude_modules Nov 10, 2024
@thebentern thebentern changed the title Exclude some niche modules by default and add to exclude_modules Exclude some niche modules by default and populate exclude_modules Nov 10, 2024
@thebentern thebentern requested a review from fifieldt November 10, 2024 12:11
Copy link
Contributor

@fifieldt fifieldt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, like the logic

@thebentern thebentern merged commit 667b4ef into master Nov 10, 2024
44 of 45 checks passed
@thebentern thebentern deleted the exclude-modules-by-default branch November 10, 2024 19:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants