Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't send to public channel #5310

Merged
merged 4 commits into from
Nov 12, 2024
Merged

Conversation

gjelsoe
Copy link
Contributor

@gjelsoe gjelsoe commented Nov 11, 2024

p->to wasn't set and had the same value as broadcast, it's now set to our own NodeNum.

@caveman99
Copy link
Member

Why would you want to send this to the originating nodenumber?

@gjelsoe
Copy link
Contributor Author

gjelsoe commented Nov 11, 2024

So it won't go on default public channel.

@GUVWAF
Copy link
Member

GUVWAF commented Nov 11, 2024

But this means it will not be sent out over LoRa at all.

You can make your primary channel private and add the public channel as a secondary channel if you don't want to send it on the public channel.

@gjelsoe
Copy link
Contributor Author

gjelsoe commented Nov 11, 2024

That kind of the issue, they don't do that and ends up spamming the channel.

@GUVWAF
Copy link
Member

GUVWAF commented Nov 11, 2024

But not sending it out over LoRa at all is not a proper solution.

@gjelsoe
Copy link
Contributor Author

gjelsoe commented Nov 11, 2024

That fair..

Closing it.

@gjelsoe gjelsoe closed this Nov 11, 2024
@gjelsoe gjelsoe deleted the DetectionSensor branch November 11, 2024 13:08
@thebentern
Copy link
Contributor

FWIW, I liked the previous idea of adding the configuration of DMing to a specific nodenum destination. Particularly for the use case of detecting a state, I think often the desired recipient is one node on the mesh rather than the whole mesh

@gjelsoe
Copy link
Contributor Author

gjelsoe commented Nov 11, 2024

That is also the one I would prefer and Garth wanted at solution that didn't involve changes that might not get into the apps.

@garthvh
Copy link
Member

garthvh commented Nov 11, 2024

A cli only solution will get essentially zero use.

@garthvh
Copy link
Member

garthvh commented Nov 11, 2024

I agree this should not be on the default key anymore, the choosing of a channel or an individual node is not something We are currently set up to manage.

@gjelsoe gjelsoe restored the DetectionSensor branch November 11, 2024 15:51
@gjelsoe gjelsoe reopened this Nov 11, 2024
@gjelsoe
Copy link
Contributor Author

gjelsoe commented Nov 11, 2024

Is this acceptable ?

@thebentern
Copy link
Contributor

Looks good to me

`p->to` wasn't set and had the same value as broadcast, it's now set to our own NodeNum.
@thebentern thebentern merged commit 0acccdf into meshtastic:master Nov 12, 2024
40 of 41 checks passed
@gjelsoe gjelsoe deleted the DetectionSensor branch November 17, 2024 14:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants