Don't attempt to save NodeDB on low-batt shutdown to prevent FS corruption #5312
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses part of #5259 by skipping the NodeDB save on low battery shutdown. This should result in minimal loss of data, because the NodeDB is saved in other domain events within the firmware regularly. Plus in any regard, it's better than potentially losing the whole enchilada.
@todd-herbert we can collaborate on this branch to try to figure out the low voltage warning startup halt, or we work that separately and push this one forward.
I was researching the best ways to persist the status that we shut down due to low battery, so that we can check attempt to run some ADC samples on the next boot. It looks like RTC slow memory could be an option: https://docs.espressif.com/projects/esp-idf/en/stable/esp32/api-guides/memory-types.html#rtc-slow-memory