CLIENT_HIDDDEN should never broadcast NeighborInfo

[fifieldt]

We set the broadcast interval to UINT_MAX in the NodeDB setup. However, in theory there would be a case where a HIDDEN node could reveal itself through this module if this setting is changed.

This change means it will never send, and will always wait UINT_MAX before trying again if called.

[GUVWAF]

Not sure this is needed, it’s an optional module already, there are other modules that would let a CLIENT_HIDDEN transmit.

Also, I don’t think it addresses the point made in #5286. It’s about another node broadcasting the node number of a CLIENT_HIDDEN when it has NeighborInfo enabled with LoRa transmit.
Anyway I don’t really see a problem with this, because when the CLIENT_HIDDEN transmits anything, it transmits its node number in the clear already, and it gets rebroadcasted by other nodes as well. From the docs: “Device that only broadcasts as needed for stealth or power savings.”, which doesn’t mean it cannot be detected in any case.

[fifieldt]

Thanks for the review :) I was just looking at what DeviceTelemetryModule does and trying to make a parallel. I bow to those with more experience about whether this is something that needs to be addressed or not - this patch took very little effort :P

[GUVWAF]

Yeah, DeviceTelemetryModule is enabled by default, NeighborInfoModule is not. I think if someone wants this on a CLIENT_HIDDEN then we should allow it, although it’s a weird choice.

[fifieldt]

OK! Will wait another day in case someone else has an opinion and will abandon.

[thebentern]

I would think this would be a very non-standard choice for a CLIENT_HIDDEN user, based on my conversation with that audience.

[fifieldt]

Abandoning, not needed.