Add unit tests for MQTT #5724
Merged
Add unit tests for MQTT #5724
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Incidentally, that original library is abandoned and I had taken a cursory swing at switching to a more maintained fork. It did not work out of the box for me, but I was unable to devote much attention to it at the time. |
|
I can give that library a try with these tests tonight and see what shakes out. |
Us forking the... more maintained fork is also an option here 😅 |
This was referenced Jan 3, 2025
thebentern
approved these changes
Jan 7, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Contributing unit tests for MQTT.
Unfortunately the
PubSubClientdoes not have virtual methods, and can't be mocked directly. Instead I've created a mockWiFiClientthat behaves as a small MQTT server to test the uplink portions of the code.