Manage when destructor is called for native webAPI #5807
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is intended to avoid a Static Initialization (Destruction) Order Fiasco issue that happens at shutdown. I believe the settingsMap is currently being destroyed before the webAPI. A log message in
PhoneAPI::close()
depends onsettingsMap[logoutputlevel]
I've also included a few changes to
PiWebServerThread::~PiWebServerThread()
to clean-up variables, and removed a seemingly unusedinstanceService
member from that class.Still to-do:[x] Test the handleAPIv1FromRadio & handleAPIv1ToRadio handler changes locallyTested locally using https://github.com/meshtastic/web/releases/download/v2.5.4/build.tar