#588 - Calculate air time. TX and RX logging is done. #601 - tbeam draws too much power from usb #596
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mc-hamster
changed the title
mc-hamster
changed the title
mc-hamster
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@geeksville Feedback would be appreciated.
The work is simple but this is the first time I'm doing anything with RadioLibInterface. I want to make sure this works for you.
Questions to help the review.
RadioLibInterface.cpp:100 - Are transmitted packets by this point both packets originated by the device and repeated mesh packets?
RadioLibInterface.cpp:261 - I think packets received at this points are designated for the current mesh network. I couldn't tell if we have validated that it is intended for the network with the crypto keys? I'd assume that validating crypto keys are optional because some channel configurations may be unencrypted.
Just as a note - I think the word "channel" may need to be revisited. It's over used in a few places.