ACK retried want_ack packets #919 #924
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Approved to run the CI |
|
Thanks for the PR! |
|
This pull request has been mentioned on Meshtastic. There might be relevant details there: https://meshtastic.discourse.group/t/meshtastic-device-1-2-48-alpha/4359/1 |
|
This pull request has been mentioned on Meshtastic. There might be relevant details there: https://meshtastic.discourse.group/t/meshtastic-device-1-2-49-5354c49-alpha/4502/1 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR addresses Issue #919 by adding some code to
ReliableRouter::shouldFilterReceivedthat ACKs retried packets that would normally just be filtered with the call toFloodingRouter::shouldFilterReceivedat the end.I'll be the first to point out that this isn't great in that it requires decoding the packet to have a channel to respond on meaning the shouldFilterRecieved inherited functions all go from
cost MeshPacket *toMeshPacket *. I'd prefer that a filter function doesn't modify the thing passed to it, but I didn't think it warranted making a copy of the packet and there's already some interesting ACK logic in the function anyway.For what it's worth, I wholeheartedly agree with this comment.