Remove promote-release.sh from Release process #958
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Something I noted during testing... In this method the tag doesn't actually materialize until the release is published from draft, which I think is preferable behavior. |
|
This pull request has been mentioned on Meshtastic. There might be relevant details there: https://meshtastic.discourse.group/t/meshtastic-device-1-2-49-5354c49-alpha/4502/1 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I tweaked the github action for release to remove this step from the release process:
run bin/promote-release.sh - this should cause github to start a release build (see the CI actions)https://meshtastic.org/docs/developers/publish
If approved this would simply kick off the process after the committed version.properties bump is pushed to master (along with the updated protos). We don't need to have a separate process to create a tag, since creating a release (draft or otherwise) in a github action implicitly creates one if you specify a tag name in the arguments.