Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Split RAK-4631 targets by base board #973

Merged
merged 4 commits into from
Dec 10, 2021
Merged

Conversation

thebentern
Copy link
Contributor

Starting to split the RAK-4631 build targets based on pin availability / differences between the base boards

@thebentern thebentern requested a review from garthvh December 8, 2021 02:45
@thebentern
Copy link
Contributor Author

Here are the uf2 binaries for each base board platform for testing

rak4631_uf2.zip

Copy link
Member

@garthvh garthvh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks really good, nice to have one actual variant file and multiple builds since I think there are more base boards coming in the spring.

@feh123
Copy link

feh123 commented Dec 8, 2021

Hi @thebentern thanks for this, I have a 19003 and a 5005-0 but they are not fully operational yet as I am waiting for more parts (I think my only 1910 is faulty).
I am trying the 5005 version at the moment but I get a strange effect - the OLED screen lighting adjustment line is always present and continually loops through running from zero to max (very quickly - <1 sec). This behaviour started seconds after the first install, I have tried altering a few preferences - I had is_router true and removed this, but so far nothing as stopped the looping. I don't have my 19003 hooked up to a screen yet so cannot see if the same behaviour affects that board. I am away today but I can check more tonight if you have any thoughts on the cause. Sorry to bring you problems!
@garthvh - I also notice that my 4631 is seen in the ios app but if I connect to it then the nodes page always shows no radios (yet there are two tbeams running). And although 1910 is currently showing a gps fix the 4631 node does not appear on the map.

@thebentern
Copy link
Contributor Author

I am trying the 5005 version at the moment but I get a strange effect - the OLED screen lighting adjustment line is always present and continually loops through running from zero to max (very quickly - <1 sec). This behaviour started seconds after the first install, I have tried altering a few preferences - I had is_router true and removed this, but so far nothing as stopped the looping.

I'm gonna double check this with my 5005. It sounds like there may be something squirrely with the button pin

@thebentern
Copy link
Contributor Author

I have reproduced the bug. I think pin 5 is incorrect. I've got something to try tomorrow.

@sachaw sachaw marked this pull request as draft December 9, 2021 08:25
@thebentern thebentern marked this pull request as ready for review December 10, 2021 02:20
@thebentern
Copy link
Contributor Author

@feh123 here is the updated firmware for the RAK-5005 with the correct pin mapping. Should be no funky display brightness holding bug now.
firmware_rak_5005.zip

@sachaw sachaw merged commit 0468358 into meshtastic:master Dec 10, 2021
@feh123
Copy link

feh123 commented Dec 10, 2021

@thebentern - the fix works well for me. Thanks!

@geeksville
Copy link
Member

This pull request has been mentioned on Meshtastic. There might be relevant details there:

https://meshtastic.discourse.group/t/meshtastic-device-1-2-49-5354c49-alpha/4502/1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants