-
Notifications
You must be signed in to change notification settings - Fork 1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Split RAK-4631 targets by base board #973
Conversation
Here are the uf2 binaries for each base board platform for testing |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks really good, nice to have one actual variant file and multiple builds since I think there are more base boards coming in the spring.
Hi @thebentern thanks for this, I have a 19003 and a 5005-0 but they are not fully operational yet as I am waiting for more parts (I think my only 1910 is faulty). |
I'm gonna double check this with my 5005. It sounds like there may be something squirrely with the button pin |
I have reproduced the bug. I think pin 5 is incorrect. I've got something to try tomorrow. |
@feh123 here is the updated firmware for the RAK-5005 with the correct pin mapping. Should be no funky display brightness holding bug now. |
@thebentern - the fix works well for me. Thanks! |
This pull request has been mentioned on Meshtastic. There might be relevant details there: https://meshtastic.discourse.group/t/meshtastic-device-1-2-49-5354c49-alpha/4502/1 |
Starting to split the RAK-4631 build targets based on pin availability / differences between the base boards