Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add E-Ink options to DisplayConfig #474

Closed
wants to merge 1 commit into from

Conversation

todd-herbert
Copy link
Contributor

Intention is to expose two new settings to users:

  • E-Ink Screensaver: what behavior to use when display updates are paused
  • E-Ink Full Sun: slower, more robust. Hopes to improve outdoor performance for some displays

Neither of these features are implemented just yet. Screensaver code is a work-in-progress: meshtastic/firmware#3477

Changes tested locally with the python CLI; unsure what work is necessary to eventually expose the new settings in the mobile apps / Web UI.

Copy link
Member

@caveman99 caveman99 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Technically that would be fine. Then again we wanted to reduce the settings, not add to them. I sense a bit of feature creep here. The direct sunlight mode is sensible, for the screensaver i'd scrap the configuration option, just pick one and use that. It's nothing that will destroy UX too badly. What abut flying 3d meshtastic logos? ;-)

@todd-herbert
Copy link
Contributor Author

I hear you. This was a reaction to feedback on the initial screensaver pull request, essentially a difference of opinion on aesthetics. The hope here was that no users gets stuck with a feature they are unhappy about. Definitely a bit of feature creep though, and yeah possibly a step too far.

Personally, after implementing the different options yesterday, I have come around and probably now prefer the subtle overlay option suggested on the firmware pull-request.

@todd-herbert
Copy link
Contributor Author

I will still look into the full-sun config option in the near future.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants