Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support multi-monitor #161

Closed
wants to merge 3 commits into from
Closed

Conversation

kayhide
Copy link

@kayhide kayhide commented Jun 4, 2020

Hello,

I updated the script and supported multi-monitor.

Using xrandr command, it lists active monitors and processes on every subsection corresponding to the monitor's position and size.

On my dual monitor environment, it works as:
image

$ xrandr --listmonitors
Monitors: 2
 0: +*eDP-1 2560/344x1440/194+0+0  eDP-1
 1: +DP-3 1920/476x1080/267+2560+0  DP-3

@AladW
Copy link
Collaborator

AladW commented Jun 25, 2020

Closing this in favor of #155, which seems less complex (no threads) and thus easier to review.

@AladW AladW closed this Jun 25, 2020
@kayhide
Copy link
Author

kayhide commented Jun 26, 2020

@AladW Hi, thanks for your consideration.
Okay I respect your decision.

I think I will go with my fork because in my environment, it takes more than 10 seconds if it's not parallelized and I don't want to make it that slow.
Besides, I have some other ideas to make it even faster while breaking backward compatibility.

Anyway, thanks for your great work!

@AladW
Copy link
Collaborator

AladW commented Jun 27, 2020

Ideally the underlying issue on slowness would be solved, rather than pave over it with multiple threads. The only reliable solution I've found so far is ffmpeg. #146 may have some ideas, but a simple implementation (read: reviewable) implementation is preferable.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants