Support DiaSDK for cross-compiling with mstorsjo/msvc-wine #14076
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vid512
force-pushed
the
diasdk-msvcwine
branch
from
6c6d022 to
59e9ef7
Compare
jpakkane
reviewed
Jan 6, 2025
| # on linux for cross-compiling, only clang with explicit MS-compatibility | ||
| # parameters) | ||
| # We'll look for '<msvc>/kits/<number>/include/<kit version>/winrt' | ||
| # in INCLUDE. |
There was a problem hiding this comment.
Where does INCLUDE come from? It is an extremely general name so it is confusing.
There was a problem hiding this comment.
It comes from script msvcenv-native.sh, which is part of mstorsjo/msvc-wine. The script is used in same way as vcvars*.bat in MSVC. You source it in your shell before building with clang-cl. The script exports INCLUDE and LIB environment variables, pointing to MSVC headers/libs. Environment variables are then consumed by clang-cl.
See: https://github.com/mstorsjo/msvc-wine?tab=readme-ov-file#use-with-clanglld-in-msvc-mode
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds support for dependency('diasdk') when cross-compiling for Windows with mstorsjo/msvc-wine environment (https://github.com/mstorsjo/msvc-wine).
As for testing: Works for me™, but no unit tests were added. If I understand things correctly, adding tests for this will require downloading and installing few GBs of Microsoft libraries with mstorsjo/msvc-wine scripts. I'm not sure if that is desired in Meson pipeline for such an obscure scenario. If yes, with a bit of help, I hope I can add it. See also: