Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Store commands as arrays. #14080

Merged
merged 1 commit into from
Jan 7, 2025
Merged

Store commands as arrays. #14080

merged 1 commit into from
Jan 7, 2025

Conversation

jpakkane
Copy link
Member

@jpakkane jpakkane commented Jan 6, 2025

No description provided.

dcbaker
dcbaker requested changes Jan 6, 2025
View reviewed changes
Copy link
Member

@dcbaker dcbaker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The commit message could use some work. Which commands? why are we storing them as lists?

mesonbuild/utils/universal.py Outdated Show resolved Hide resolved
eli-schwartz
eli-schwartz reviewed Jan 6, 2025
View reviewed changes
mesonbuild/utils/universal.py Outdated Show resolved Hide resolved
mesonbuild/interpreter/interpreter.py Outdated Show resolved Hide resolved
@jpakkane jpakkane force-pushed the cmdarrays branch 2 times, most recently from 29108c2 to ae2b4d2 Compare January 6, 2025 22:47
@jpakkane jpakkane force-pushed the cmdarrays branch 3 times, most recently from e8607eb to 4ccb272 Compare January 6, 2025 22:56
eli-schwartz
eli-schwartz reviewed Jan 6, 2025
View reviewed changes
mesonbuild/utils/universal.py Outdated Show resolved Hide resolved
mesonbuild/utils/universal.py Outdated Show resolved Hide resolved
@jpakkane jpakkane force-pushed the cmdarrays branch 3 times, most recently from 8e1cd2d to 6f90b79 Compare January 7, 2025 14:30
dcbaker
dcbaker requested changes Jan 7, 2025
View reviewed changes
Copy link
Member

@dcbaker dcbaker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since you're using a class, I think it's worth using a few default values to avoid having to repeat ourselves.

mesonbuild/utils/universal.py Outdated Show resolved Hide resolved
mesonbuild/utils/universal.py Outdated Show resolved Hide resolved
mesonbuild/utils/universal.py Outdated Show resolved Hide resolved
mesonbuild/utils/universal.py Outdated Show resolved Hide resolved
mesonbuild/utils/universal.py Show resolved Hide resolved
@jpakkane jpakkane merged commit dfe5cbb into master Jan 7, 2025
43 of 44 checks passed
@jpakkane jpakkane deleted the cmdarrays branch January 7, 2025 23:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eli-schwartz eli-schwartz eli-schwartz left review comments

@dcbaker dcbaker dcbaker requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jpakkane @dcbaker @eli-schwartz