Make it possible to run CI's scripts in forks and locally #121
Comments
|
Ah, so thats why I got nonsense errors when I pushed a new PR branch to this repo. |
|
Maybe instead of checking changed files to know which wraps needs to be sanity checked, I could just rely on the new release tags. As long as the PR is not making new releases, who cares if it's not conformant? |
xclaesse
added a commit
to xclaesse/wrapdb
that referenced
this issue
Aug 2, 2021
trilom/file-changes-action action has issues and it prevents running sanity checks locally. Instead of relying on the changed files to know which wraps are modified by a PR, rely on the added release tags. Fixes: mesonbuild#121.
xclaesse
added a commit
that referenced
this issue
Aug 5, 2021
trilom/file-changes-action action has issues and it prevents running sanity checks locally. Instead of relying on the changed files to know which wraps are modified by a PR, rely on the added release tags. Fixes: #121.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
The way CI is currently configured makes it basically impossible to check things before submitting PR and then annoying everyone watching the repo with test commits.
The first issue is trilom/file-changes-action action that works in a very strange way in general and I would argue is basically broken: trilom/file-changes-action#116
The second issue related to that is that it is not possible to run
sanity_checks.pylocally due to the fact that it relies infiles.jsonin the home folder.From what I understand it is basically necessary to find out what files have changed as of commit on which the script is running relatively to:
masterif not onmasterbranchmasterrevision right before current commit otherwiseIf there was a script that does this just by using
git diffor something, that would make it much nicer to work with.The text was updated successfully, but these errors were encountered: