multi-dc-seed-sync #120
multi-dc-seed-sync #120
Conversation
| @@ -36,6 +40,17 @@ public static String get(@NotNull final String key) { | |||
| } | |||
|
|
|||
| @NotNull | |||
| public static Map<String, String> optionsStart(@NotNull final String prefix, final boolean trimPrefix) { | |||
There was a problem hiding this comment.
please rename method to filterStartsWith(@NotNull final String prefix, final boolean trimPrefix).
The name option on line 38 was used to represent an optional value for a given key, but in this scenario we're already returning a 0-many data structure we won't need option in the name. In actuality we're really filtering all of the environment down to those entries whose key begins with prefix.
|
@dmitrypekar See note about ObjectMapper. Once that's fixed, please rebase squash this whole PR in prep for merge. |
|
Squashed to a single commit. Could be merged now. |
|
Merged, thanks @dmitrypekar. |
|
I've got a preliminary change to the package/config definition for the universe that I'll and can get a pr of soon so that we can provide this new config for dcos installs. |
Hey, Ben.
Just pushed final changes to support dc syncing.
For now I am going to run some more tests (99% that they would pass).
During that time you can review the code and post your comments.