This repository has been archived by the owner on Jan 10, 2019. It is now read-only.
Set LD_LIBRARY_PATH so Cassandra runs on Test/Continuous Clusters #125
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -93,7 +93,8 @@ | |||
| ); | |||
|
|
|||
| private static final Map<String, String> executorEnv = unmodifiableHashMap( | |||
| tuple2("JAVA_OPTS", "-Xms256m -Xmx256m") | |||
| tuple2("JAVA_OPTS", "-Xms256m -Xmx256m"), | |||
| tuple2("MESOSPHERE_LD_LIBRARY_PATH", "/opt/mesosphere/lib") | |||
There was a problem hiding this comment.
On non dcos clusters (most major linux distributions), LD library path is typically located under "/usr/local/lib". I'm not very familiar with this code, but I wanted to double check that the default value is correct here.
There was a problem hiding this comment.
This value is appended to the path at executor start time. You're right that it's normally not there and will only be there in DCOS.
I want to test this out on DCOS and mesos to make sure that it works in both locations then I'll merge it.
There was a problem hiding this comment.
This has been tested on DCOS and mesos clusters now.
|
One comment which is pretty important. Other than that, LGTM. Any objections @BenWhitehead before merging? |
BenWhitehead
added a commit
that referenced
this pull request
Jul 30, 2015
Set LD_LIBRARY_PATH so Cassandra runs on Test/Continuous Clusters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.