Complete KeywordExtractConfigBuilder coverage. Clean code. #106
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #106 +/- ##
==========================================
+ Coverage 84.01% 84.74% +0.73%
==========================================
Files 8 8
Lines 1989 2052 +63
==========================================
+ Hits 1671 1739 +68
+ Misses 318 313 -5 ☔ View full report in Codecov by Sentry. |
CodSpeed Performance ReportMerging #106 will not alter performanceComparing Summary
|
messense
reviewed
Apr 13, 2024
Previous code was missing some coverage. These additional tests fix it. Also, updated the remove_stop_words() api to use AsRef so both literals and string objects can be passed in. There is no effect on copies/moves in this setup. Lastly, cleaned up the DEFAULT_STOP_WORDS creation code to read a little more idiomatically.
messense
approved these changes
Apr 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previous code was missing some coverage. These additional tests fix it.
Also, updated the remove_stop_words() api to use AsRef so
both literals and string objects can be passed in. There is no effect on
copies/moves in this setup.
Lastly, cleaned up the DEFAULT_STOP_WORDS creation code to read
a little more idiomatically.