Wrap calculations in remember

metabrainz · Feb 5, 2025 · 9a126a2 · 9a126a2
1 parent e4be5bc
commit 9a126a2
Showing 1 changed file with 14 additions and 9 deletions.
diff --git a/...in/java/org/listenbrainz/android/ui/screens/brainzplayer/overview/AlbumsOverviewScreen.kt b/...in/java/org/listenbrainz/android/ui/screens/brainzplayer/overview/AlbumsOverviewScreen.kt
@@ -22,23 +22,28 @@ import org.listenbrainz.android.ui.components.ListenCardSmall
 import org.listenbrainz.android.ui.theme.ListenBrainzTheme
 import androidx.compose.foundation.lazy.LazyColumn
 import androidx.compose.foundation.lazy.items
+import androidx.compose.runtime.remember
 
 @Composable
 fun AlbumsOverViewScreen(
     albums: List<Album>,
     onPlayIconClick: (Album) -> Unit
 ) {
-    val albumsStarting: MutableMap<Char, MutableList<Album>> = mutableMapOf()
+    val albumsStarting = remember(albums) {
+        val albumsStarting = mutableMapOf<Char, MutableList<Album>>()
 
-    for (i in 0..25) {
-        albumsStarting['A' + i] = mutableListOf()
-    }
-    albumsStarting['#'] = mutableListOf()
+        for (i in 0..25) {
+            albumsStarting['A' + i] = mutableListOf()
+        }
+        albumsStarting['#'] = mutableListOf()
+
+        for (album in albums) {
+            val title = album.title.trim()
+            val startingLetter = title.firstOrNull()?.uppercaseChar()?.takeIf { it.isLetter() } ?: '#'
+            albumsStarting[startingLetter]?.add(album)
+        }
 
-    for (album in albums) {
-        val title = album.title.trim()
-        val startingLetter = title.firstOrNull()?.uppercaseChar()?.takeIf { it.isLetter() } ?: '#'
-        albumsStarting[startingLetter]?.add(album)
+        albumsStarting as Map<Char, List<Album>>
     }
 
     LazyColumn(