Skip to content

Commit

Permalink
Merge pull request #530 from 07jasjeet/main
Browse files Browse the repository at this point in the history
Fix login flow
  • Loading branch information
07jasjeet authored Jan 22, 2025
2 parents c4f54ec + edb4f10 commit 9f3783d
Show file tree
Hide file tree
Showing 5 changed files with 140 additions and 51 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,7 @@ import androidx.compose.material3.SnackbarHostState
import androidx.compose.runtime.Composable
import androidx.compose.runtime.LaunchedEffect
import androidx.compose.ui.Modifier
import androidx.hilt.navigation.compose.hiltViewModel
import androidx.navigation.NavController
import androidx.navigation.NavHostController
import androidx.navigation.NavOptionsBuilder
Expand All @@ -13,14 +14,19 @@ import androidx.navigation.compose.NavHost
import androidx.navigation.compose.composable
import androidx.navigation.compose.rememberNavController
import androidx.navigation.navArgument
import androidx.navigation.navigation
import kotlinx.coroutines.flow.first
import org.listenbrainz.android.model.AppNavigationItem
import org.listenbrainz.android.ui.screens.album.AlbumScreen
import org.listenbrainz.android.ui.screens.artist.ArtistScreen
import org.listenbrainz.android.ui.screens.brainzplayer.BrainzPlayerScreen
import org.listenbrainz.android.ui.screens.explore.ExploreScreen
import org.listenbrainz.android.ui.screens.feed.FeedScreen
import org.listenbrainz.android.ui.screens.profile.LoginScreen
import org.listenbrainz.android.ui.screens.profile.ProfileScreen
import org.listenbrainz.android.ui.screens.settings.SettingsScreen
import org.listenbrainz.android.viewmodel.DashBoardViewModel
import org.listenbrainz.android.viewmodel.UserViewModel

@Composable
fun AppNavigation(
Expand Down Expand Up @@ -75,6 +81,17 @@ fun AppNavigation(
composable(route = AppNavigationItem.Explore.route) {
ExploreScreen()
}
composable(
route = AppNavigationItem.Profile.route
) {
val viewModel = hiltViewModel<DashBoardViewModel>()
LoginScreen {
val username = viewModel.usernameFlow.first()
if (username.isNotBlank()) {
goToUserProfile(username)
}
}
}
composable(
route = "${AppNavigationItem.Profile.route}/{username}",
arguments = listOf(
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -89,9 +89,13 @@ fun BottomNavigationBar(

when (item.route) {
AppNavigationItem.Profile.route -> {
navController.navigate(if (!username.isNullOrBlank()) "profile/${username}" else "profile/guest"){
navController.navigate(AppNavigationItem.Profile.route + if (!username.isNullOrBlank()) "/${username}" else ""){
// Avoid building large backstack
popUpTo(AppNavigationItem.Feed.route){
if (username.isNullOrBlank()) {
inclusive = true
}

saveState = true
}
// Avoid copies
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -47,7 +47,9 @@ class LoginActivity : ComponentActivity() {
contentAlignment = Alignment.Center
) {
// FIXME: Security certificate warning in API 24 and below.
ListenBrainzLogin(viewModel)
ListenBrainzLogin(viewModel) {
finish()
}
}
}
}
Expand All @@ -56,10 +58,9 @@ class LoginActivity : ComponentActivity() {

@SuppressLint("SetJavaScriptEnabled")
@Composable
fun ListenBrainzLogin(viewModel: ListensViewModel) {
fun ListenBrainzLogin(viewModel: ListensViewModel, onLoginSuccess: (String) -> Unit) {
val url = "https://listenbrainz.org/login"
val coroutineScope = rememberCoroutineScope()
val activity = LocalContext.current.getActivity()
Row(modifier = Modifier.fillMaxWidth(),
verticalAlignment = Alignment.CenterVertically,
horizontalArrangement = Arrangement.Center
Expand Down Expand Up @@ -90,7 +91,7 @@ fun ListenBrainzLogin(viewModel: ListensViewModel) {
// Token is not null or empty.
coroutineScope.launch {
viewModel.saveUserDetails(token)
activity?.finish()
onLoginSuccess(token)
}
}
clearCookies()
Expand Down
Original file line number Diff line number Diff line change
@@ -0,0 +1,111 @@
package org.listenbrainz.android.ui.screens.profile

import android.content.Intent
import android.widget.Toast
import androidx.compose.foundation.layout.Arrangement
import androidx.compose.foundation.layout.Column
import androidx.compose.foundation.layout.Spacer
import androidx.compose.foundation.layout.aspectRatio
import androidx.compose.foundation.layout.fillMaxSize
import androidx.compose.foundation.layout.fillMaxWidth
import androidx.compose.foundation.layout.height
import androidx.compose.foundation.layout.padding
import androidx.compose.foundation.rememberScrollState
import androidx.compose.foundation.verticalScroll
import androidx.compose.material3.ButtonDefaults
import androidx.compose.material3.Text
import androidx.compose.material3.TextButton
import androidx.compose.runtime.Composable
import androidx.compose.runtime.getValue
import androidx.compose.runtime.setValue
import androidx.compose.runtime.mutableStateOf
import androidx.compose.runtime.remember
import androidx.compose.runtime.rememberCoroutineScope
import androidx.compose.ui.Alignment
import androidx.compose.ui.Modifier
import androidx.compose.ui.res.stringResource
import androidx.compose.ui.text.font.FontWeight
import androidx.compose.ui.text.style.TextAlign
import androidx.compose.ui.tooling.preview.PreviewLightDark
import androidx.compose.ui.unit.dp
import androidx.compose.ui.unit.sp
import androidx.hilt.navigation.compose.hiltViewModel
import com.airbnb.lottie.compose.LottieAnimation
import com.airbnb.lottie.compose.LottieCompositionSpec
import com.airbnb.lottie.compose.LottieConstants
import com.airbnb.lottie.compose.rememberLottieComposition
import kotlinx.coroutines.launch
import org.listenbrainz.android.R
import org.listenbrainz.android.ui.theme.ListenBrainzTheme

@Composable
fun LoginScreen(
navigateToUserProfile: suspend () -> Unit,
) {
val scope = rememberCoroutineScope()
var startLogin by remember { mutableStateOf(false) }
Column(
modifier = Modifier
.fillMaxSize()
.verticalScroll(rememberScrollState()),
horizontalAlignment = Alignment.CenterHorizontally,
verticalArrangement = Arrangement.Center
) {
val comp by rememberLottieComposition(spec = LottieCompositionSpec.RawRes(R.raw.login))
LottieAnimation(
modifier = Modifier
.fillMaxWidth(0.7f)
.aspectRatio(1f),
composition = comp,
iterations = LottieConstants.IterateForever,
)

Spacer(modifier = Modifier.height(16.dp))

TextButton(
onClick = {
startLogin = true
},
modifier = Modifier
.fillMaxWidth()
.padding(horizontal = 10.dp),
colors = ButtonDefaults.buttonColors(containerColor = ListenBrainzTheme.colorScheme.lbSignature)
) {
Text(
modifier = Modifier.padding(horizontal = 24.dp, vertical = 8.dp),
text = stringResource(id = R.string.login),
color = ListenBrainzTheme.colorScheme.onLbSignature,
fontWeight = FontWeight.Bold,
fontSize = 16.sp
)
}

Text(
text = stringResource(id = R.string.login_prompt),
color = ListenBrainzTheme.colorScheme.text,
fontSize = 18.sp,
textAlign = TextAlign.Center,
modifier = Modifier.padding(top = 16.dp, start = 10.dp, end = 10.dp)
)
}

if (startLogin) {
ListenBrainzLogin(
viewModel = hiltViewModel(),
onLoginSuccess = {
scope.launch {
navigateToUserProfile()
startLogin = false
}
}
)
}
}

@PreviewLightDark
@Composable
private fun Preview() {
ListenBrainzTheme {
LoginScreen {}
}
}
Original file line number Diff line number Diff line change
Expand Up @@ -75,52 +75,8 @@ fun ProfileScreen(
goToArtistPage = goToArtistPage
)
}
else -> {
Column(
modifier = Modifier
.fillMaxSize()
.verticalScroll(rememberScrollState()),
horizontalAlignment = Alignment.CenterHorizontally,
verticalArrangement = Arrangement.Center
) {

val comp by rememberLottieComposition(spec = LottieCompositionSpec.RawRes(R.raw.login))
LottieAnimation(
modifier = Modifier
.fillMaxWidth(0.7f)
.aspectRatio(1f),
composition = comp,
iterations = LottieConstants.IterateForever,
)

Spacer(modifier = Modifier.height(16.dp))

Button(
onClick = {
context.startActivity(Intent(context, LoginActivity::class.java))
},
modifier = Modifier
.fillMaxWidth()
.height(50.dp)
.padding(horizontal = 10.dp),
colors = ButtonDefaults.buttonColors(backgroundColor = MaterialTheme.colors.onSurface)
) {
Text(
text = stringResource(id = R.string.login),
color = Color.White,
fontWeight = FontWeight.Bold,
fontSize = 16.sp
)
}

Text(
text = stringResource(id = R.string.login_prompt),
color = androidx.compose.material3.MaterialTheme.colorScheme.onSurface,
fontSize = 18.sp,
textAlign = TextAlign.Center,
modifier = Modifier.padding(top = 16.dp, start = 10.dp, end = 10.dp)
)
}
else -> LoginScreen {
goToUserProfile(viewModel.appPreferences.username.get())
}
}
}

0 comments on commit 9f3783d

Please sign in to comment.