MOBILE-160,184: Listen Scrobble fixes and improvements #336
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When a new media app is discovered, it is opted out by default. Only user can opt-in the new discovered app.
akshaaatt
reviewed
Jan 15, 2024
There was a problem hiding this comment.
Thanks for working on this PR but we should have discussed this before implementing. We simply cannot move to whitelisting. This changes the UX entirely and we were not in the favour of doing this from the beginning. We want to reduce the number of steps the user takes to start submitting listens. We need to have a discussion on this properly before moving ahead with this work.
Dev to Main
Since all datastore preferences need certain similar functions, this interface was created.
07jasjeet
changed the title
07jasjeet
changed the title
07jasjeet
changed the title
|
@07jasjeet why is this PR made against |
Oops, forgot to change it. |
akshaaatt
requested changes
Jan 20, 2024
app/src/main/java/org/listenbrainz/android/repository/preferences/AppPreferencesImpl.kt
Show resolved
Hide resolved
app/src/main/java/org/listenbrainz/android/service/ListenScrobbleService.kt
Outdated
Show resolved
Hide resolved
akshaaatt
requested changes
Jan 21, 2024
app/src/main/java/org/listenbrainz/android/di/brainzplayer/DaoModule.kt
Outdated
Show resolved
Hide resolved
1) Revert gradle version change. 2) Changed name of ListenService and ListensDatabase.
akshaaatt
reviewed
Jan 22, 2024
app/src/main/java/org/listenbrainz/android/di/brainzplayer/DatabaseModule.kt
Outdated
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes MOBILE-160 and MOBILE-184.
Also Closes #331 and #324
Summary
Now onwards, whenever a new media app is discovered, it is opted out by default. Only user can opt-in the newly discovered media app. This helps avoid unintended scrobbles with newly discovered apps.
Migration from Blacklist to Whitelist has been handled.