Minor-UI-Logic-Bug #541
Merged
Minor-UI-Logic-Bug #541
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi,@07jasjeet is everything looks good? |
07jasjeet
approved these changes
Jan 29, 2025
There was a problem hiding this comment.
Hi @rahul31124, thanks for identifying this bug and fixing it. Changes LGTM.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR resolves the issue of following and unfollowing a user. Previously, in the onFollowButtonClick function, the isFollowing status was passed . If the status was false, the followUser function would be called, even if the user was already following, leading to redundant actions. I have updated the logic so that if the user is not following, false will be passed to follow, and if the user is already following, true will be passed to unfollow the user.
Before
Bug_Follow_Button_Before.webm
After
Bug_Follow_Button_After.webm