Fixed-Lag-In-SongsOverviewScreen #543
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @07jasjeet,with these changes now there is no lag let me know if any additional changes are required. |
07jasjeet
approved these changes
Feb 1, 2025
There was a problem hiding this comment.
Hi @rahul31124, thanks for the contribution. I have made some fixes to your changes and added empty state. Please take care of covering all the cases (empty state here) when building something, it really helps you with defining your work's quality. Great work on finding this bug!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR resolves the lag and freezing issues in SongsOverviewScreen by implementing Lazycolumn and coroutines, heavy operations are moved off the main thread, resulting in improved performance and reduced UI freezing and lag
Before
Lag_Issue_Before.mp4
After
Lag_Issue_After.mp4