Fixed crash and improve performance in AlbumsOverViewScreen

[rahul31124]

This PR fixes a crash that happened when clicking on an album with no songs by adding proper null safety Checks a Toast is now shown if the album has 0 songs,also improves performance by use of LazyColumn instead of Column

Before

Crash_Issue_Before.mp4

After

Crash_Issue_After.mp4

[07jasjeet]

Hi @rahul31124, can you share what was the crash?

[rahul31124]

Hi @07jasjeet,actually when we click on a album that has 0 song means nothing to play at that time the app crashes

[07jasjeet]

@rahul31124 I understand that but there might be some logs when the crash happened. Can you share those? We might need to fix these cases deeper in BP view-model rather than on call sites to avoid future crashes.

[rahul31124]

@07jasjeet the logs i got

E [AppErrors] null InputStream [CONTEXT service_id=254 ]
java.io.IOException: null InputStream
at daoj.b(:com.google.android.gms@[email protected] (100400-713002902):184)
at damr.l(:com.google.android.gms@[email protected] (100400-713002902):7)
at daml.apply(:com.google.android.gms@[email protected] (100400-713002902):39)
at tet.apply(:com.google.android.gms@[email protected] (100400-713002902):5)
at tff.apply(:com.google.android.gms@[email protected] (100400-713002902):45)
at dwnz.a(:com.google.android.gms@[email protected] (100400-713002902):3)
at efzq.a(:com.google.android.gms@[email protected] (100400-713002902):13)
at enjz.d(:com.google.android.gms@[email protected] (100400-713002902):3)
at enkb.run(:com.google.android.gms@[email protected] (100400-713002902):38)
at enln.execute(:com.google.android.gms@[email protected] (100400-713002902):1)
at enjv.h(:com.google.android.gms@[email protected] (100400-713002902):1)
at enjv.hp(:com.google.android.gms@[email protected] (100400-713002902):40)
at enkb.g(:com.google.android.gms@[email protected] (100400-713002902):13)
at dwnr.a(:com.google.android.gms@[email protected] (100400-713002902):20)
at efzp.a(:com.google.android.gms@[email protected] (100400-713002902):13)
at enlu.a(:com.google.android.gms@[email protected] (100400-713002902):20)
at ennx.a(:com.google.android.gms@[email protected] (100400-713002902):3)
at enmy.run(:com.google.android.gms@[email protected] (100400-713002902):19)
at ennz.run(:com.google.android.gms@[email protected] (100400-713002902):5)
at enlw.run(:com.google.android.gms@[email protected] (100400-713002902):53)
at enln.execute(:com.google.android.gms@[email protected] (100400-713002902):1)
at enlw.execute(:com.google.android.gms@[email protected] (100400-713002902):76)
at enjv.h(:com.google.android.gms@[email protected] (100400-713002902):1)
at enjv.hp(:com.google.android.gms@[email protected] (100400-713002902):40)
at enly.b(:com.google.android.gms@[email protected] (100400-713002902):33)
at dwnv.i(:com.google.android.gms@[email protected] (100400-713002902):18)
at dwod.a(:com.google.android.gms@[email protected] (100400-713002902):10)
at efzq.a(:com.google.android.gms@[email protected] (100400-713002902):13)
at enjz.d(:com.google.android.gms@[email protected] (100400-713002902):3)
at enkb.run(:com.google.android.gms@[email protected] (100400-713002902):38)
at enln.execute(:com.google.android.gms@[email protected] (100400-713002902):1)
at enjv.h(:com.google.android.gms@[email protected] (100400-713002902):1)
at enjv.hp(:com.google.android.gms@[email protected] (100400-713002902):40)
at enkb.g(:com.google.android.gms@[email protected] (100400-713002902):13)
at dwob.a(:com.google.android.gms@[email protected] (100400-713002902):20)
at efzp.a(:com.google.android.gms@[email protected] (100400-713002902):13)
at enlu.a(:com.google.android.gms@[email protected] (100400-713002902):20)
at ennx.a(:com.google.android.gms@[email protected] (100400-713002902):3)
at enmy.run(:com.google.android.gms@[email protected] (100400-713002902):19)
at ennz.run(:com.google.android.gms@[email protected] (100400-713002902):5)
at enlw.run(:com.google.android.gms@[email protected] (100400-713002902):53)
at enln.execute(:com.google.android.gms@[email protected] (100400-713002902):1)
at enlw.execute(:com.google.android.gms@[email protected] (100400-713002902):76)
at enjv.h(:com.google.android.gms@[email protected] (100400-713002902):1)
at enjv.hp(:com.google.android.gms@[email protected] (100400-713002902):40)
at enly.b(:com.google.android.gms@[email protected] (100400-713002902):33)
at dwoj.c(:com.google.android.gms@[email protected] (100400-713002902):56)
at dwoj.b(:com.google.android.gms@[email protected] (100400-713002902):10)
at com.google.android.gms.stats.service.DropBoxEntryAddedChimeraService.a(:com.google.android.gms@[email protected] (100400-713002902):379)

[rahul31124]

Hi @07jasjeet, just following up since you asked for the logs. Let me know if my changes are enough or if anything else is needed.

[07jasjeet]

These logs look irrelevant, are you sure these are the ones?

[rahul31124]

@07jasjeet,Yes i am getting these logs additionally i have added my logs to see the title as well as the size.
1

2

[07jasjeet]

Please add package:com.listenbrainz.android.debug is:crash int the filter bar

[rahul31124]

[07jasjeet]

@rahul31124 have you joined meb irc channel?

[rahul31124]

Yes I Now I have joined

[rahul31124]

May be There is a problem in the channel so i am sharing the screenshot here

[rahul31124]

Hi @07jasjeet,
I believe the issue is most likely related to how Telegram marks or handles audio metadata. From my observation, when audio files are stored in the Telegram folder, the metadata might not be properly registered or updated in the MediaStore, causing inconsistencies with fetching and displaying the files correctly.

In the Play Store version, I didn't notice any Telegram albums showing up, which suggests that Telegram may handle file indexing differently.

Since this crash doesn't happen consistently, I think adding a null-safety check here would be a good precaution to prevent potential issues, especially with apps like Telegram that may have inconsistent metadata handling.

[07jasjeet]

Looks good for now. Thanks for the contribution @rahul31124!