mirrord container docker check run #2933
Open
+99
−32
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DmitryDodzin
force-pushed
the
dimad/mbe-529-mirrord-container-docker-run-nginx-fails
branch
from
fb7fc9e
to
592f7b5
Compare
meowjesty
requested changes
Nov 26, 2024
| @@ -57,19 +61,28 @@ impl RuntimeCommandBuilder { | |||
| } | |||
| } | |||
|
|
|||
| pub fn add_volume<H, C>(&mut self, host_path: H, container_path: C) | |||
| pub fn add_volume<H, C>(&mut self, host_path: H, container_path: C, readonly: bool) | |||
There was a problem hiding this comment.
Do we need the functions in this file to be pub? Reason I'm not a fan of pub all the things is that it doesn't warn you if they're not being used.
There was a problem hiding this comment.
is pub(super) fine?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For mirrord container command check that the sidecar container is started after it is created when running with docker runtime
relevant for #2927