Transitive closure to main #4454
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
icecream17
approved these changes
Nov 27, 2024
I did not follow this activity (intensively enough) in the past, so I currently see no benefit to introduce a new definition in main. The proof of ~frmin becomes (a lot) longer. Maybe you can create an issue for this, and provide an outline there about the objectives and how you want to proceed. And that the definitions TrPred and t+will be eliminated at the end (entirely replaced by t++?). |
|
Issue opened in #4456 |
avekens
reviewed
Nov 29, 2024
changes-set.txt
Outdated
| @@ -93,6 +93,14 @@ make a github issue.) | |||
|
|
|||
| DONE: | |||
| Date Old New Notes | |||
| 27-Nov-24 eldifsucnn [same] moved from SF's mathbox to main set.mm | |||
There was a problem hiding this comment.
Indentation: please revove one space in front of "moved from"
avekens
approved these changes
Nov 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In my effort to eliminate TrPred and t+, this PR moved t++ to main and reproves frmin