Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adding unit tests for Transaction Message compilation and fixing public key sorting issue #109

Merged
merged 2 commits into from
Oct 18, 2022
Merged

Adding unit tests for Transaction Message compilation and fixing public key sorting issue #109

merged 2 commits into from
Oct 18, 2022

Conversation

MirekR
Copy link

@MirekR MirekR commented Oct 18, 2022

Description

  • Kotlin implementation was returning different result on Transaction.compileMessage() compare to solana/web3.js implementation. This was causing issues with partially signed messages from server (NodeJs + Typescript)

Work Completed

@ajamaica
Copy link
Contributor

Great catch!

@ajamaica ajamaica merged commit 82e3dd8 into metaplex-foundation:master Oct 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ajamaica ajamaica ajamaica approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@MirekR @ajamaica