Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Kotlin serializer on sockets and Removes Moshi #110

Merged
merged 8 commits into from
Oct 25, 2022
Merged

Kotlin serializer on sockets and Removes Moshi #110

merged 8 commits into from
Oct 25, 2022

Conversation

ajamaica
Copy link
Contributor

*This PR is requires #107 *

Description

  • Aims to clean the code and finish the transition to Kotlin Serialization on sockets

Work Completed

  • Removes Moshi from SolanaKT
  • Rewrite on Serialization Test
  • Rewrites Serialization for Sockets
  • Remove Moshi generated libraries
  • Fixes the token parsing to use new JSON decoder

API Changes

  • Mostly all Socket objects are returning a different object RpcResponse -> RpcResponseSerializable, its very likely we rename back to RpcResponse.

Testing

  • New tests for Decoding
  • New test Sockets
  • Fixes tests for Token Parsing

@ajamaica ajamaica requested a review from Funkatronics October 18, 2022 16:41
@ajamaica ajamaica marked this pull request as ready for review October 20, 2022 13:47
@ajamaica ajamaica force-pushed the feature/kotlin-serializer-sockets branch from d2ea922 to 315ab52 Compare October 20, 2022 13:49
@ajamaica ajamaica mentioned this pull request Oct 21, 2022
Merged
@ajamaica ajamaica requested a review from Funkatronics October 25, 2022 15:10
@Funkatronics Funkatronics merged commit 9c88971 into master Oct 25, 2022
@ajamaica ajamaica deleted the feature/kotlin-serializer-sockets branch October 25, 2022 15:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Funkatronics Funkatronics Funkatronics approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ajamaica @Funkatronics