-
Notifications
You must be signed in to change notification settings - Fork 37
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update app to use enviroment RPC for GitHub actions #123
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Update Kotlin version to `1.7.20` - Add environment variables for DevNet validator URL and WSS - Update `compileSdkVersion` and `targetSdkVersion` to `33` - Change Solana constructor to use custom RPCEndpoint - Lower numeric tolerance for test files [build.gradle] - Update the Kotlin version from `1.7.10` to `1.7.20` [solana/src/test/java/com/solana/api/ApiTests.kt] - Add system properties for validator URL and WSS - Change Solana constructor to use custom RPCEndpoint - Add imports for `URL` and `Network` - Lower numeric tolerance for test files [.github/workflows/android.yml] - Add environment variables for DevNet validator URL and WSS [solana/src/test/java/com/solana/networking/socket/SocketTests.kt] - Add imports for DEVNET_VALIDATOR_URL and DEVNET_VALIDATOR_WSS - Modify the socket initialization to use System.getProperty for the URL and WSS - Add Network.devnet as an argument for the socket initialization [solana/build.gradle] - Update `compileSdkVersion` from `30` to `33` - Update `targetSdkVersion` from `30` to `33`
- Update Solana and RxSolana to use HTTPS protocol for `mainnetBetaSolana`, `devnetSolana`, and `testnetSolana` endpoints - Remove `mainnetBetaSerum` endpoint [solana/src/main/java/com/solana/networking/RPCEndpoint.kt] - Remove `mainnetBetaSerum` endpoint - Change `mainnetBetaSolana`, `devnetSolana`, and `testnetSolana` endpoints to use HTTPS protocol
- Remove unnecessary `Solana` initialization from Action.kt - Add `getTokenWallets` test to Action.kt [rxSolana/src/test/java/com/solana/rxsolana/actions/Action.kt] - Remove unnecessary `Solana` initialization - Add `getTokenWallets` test
- Update the default URLs for `DEVNET_VALIDATOR_URL` and `DEVNET_VALIDATOR_WSS` to use the value of the system property [solana/src/test/java/com/solana/api/ApiTests.kt] - Change the default URL for `DEVNET_VALIDATOR_URL` to the value of the system property - Change the default URL for `DEVNET_VALIDATOR_WSS` to the value of the system property [rxSolana/src/test/java/com/solana/rxsolana/api/Methods.kt] - Change the default value of `DEVNET_VALIDATOR_URL` and `DEVNET_VALIDATOR_WSS` from `https://api.devnet.solana.com` to a value defined by the `System.getProperty()` method [rxSolana/src/test/java/com/solana/rxsolana/actions/Action.kt] - Replace hardcoded devnet URLs with system property values
- Update build.gradle files to read RPC URL properties for testing - Replace manual initialization of `SolanaSocket` with `generateSolanaSocket()` - Replace `HttpNetworkingRouter` with `SolanatestsUtils.generateSolanaConnection()` - Update compileSdkVersion and targetSdkVersion to `33` - Change Kotlin code style from "obsolete" to "official" - Add two RPC URLs used for [solana/build.gradle] - Add ability to read RPC URL properties for testing - Add ability to use a local validator for testing - Add `RPC_URL` buildConfigField for testing [solana/src/test/java/com/solana/networking/socket/SocketTests.kt] - Add import for `SolanaTestsUtils` - Remove imports for `DEVNET_VALIDATOR_URL` and `DEVNET_VALIDATOR_WSS` - Replace manual initialization of `SolanaSocket` with `generateSolanaSocket()` - Add `testSocketConnected()` test [.github/workflows/android.yml] - Change the name of the Github Action from "Run Gradle Command" to "Run Tests" - Replace the command to run Gradle with a command to run tests using parameters from the environment variables [rxSolana/build.gradle] - Update compileSdkVersion and targetSdkVersion to `33` - Add properties to read RPC URL from testing - Add option to use local validator - Set RPC URL in buildConfigField [rxSolana/src/test/java/com/solana/rxsolana/actions/Action.kt] - Remove `HttpNetworkingRouter` initialization - Replace it with `SolanatestsUtils.generateSolanaConnection()` - Remove the `Network` and `RPCEndpoint` imports - Add an `SolanatestsUtils` import - Add a test for sending SOL [rxSolana/src/test/java/com/solana/rxsolana/SolanaTestsUtils.kt] - Add a utility object `SolanatestsUtils` for generating a Solana connection - Add a function to generate a Solana connection with custom `RPC_URL` and `Network.devnet` [solana/src/test/java/com/solana/SolanaTestsUtils.kt] - Add SolanaTestsUtils utility class - Generate Solana connection - Generate SolanaSocket with debug logs enabled [rxSolana/src/test/java/com/solana/rxsolana/api/Methods.kt] - Replace `HttpNetworkingRouter` with `SolanatestsUtils.generateSolanaConnection()` - Remove references to `DEVNET_VALIDATOR_URL` and `DEVNET_VALIDATOR_WSS` - Add `SolanatestsUtils` import [solana/src/test/java/com/solana/api/ApiTests.kt] - Add `SolanaTestsUtils` import - Move `solana` initialization to `SolanaTestsUtils` - Remove unused `DEVNET_VALIDATOR_URL` and `DEVNET_VALIDATOR_WSS` constants - Add a test for `getRecentBlockhash` function [gradle.properties] - Change Kotlin code style from "obsolete" to "official" - Add two RPC URLs used for testing - Add localValidator flag set to `false`
- Changed `Run Tests` step in `.github/workflows/android.yml` to use `DEVNET_VALIDATOR_URL` environment variable [.github/workflows/android.yml] - Change `Run Tests` step to use `DEVNET_VALIDATOR_URL` environment variable
- Replace the `Run Tests` step with an Android Gradle Action in .github/workflows/android.yml - Pass the `DEVNET_VALIDATOR_URL` as an argument to the `test` command [.github/workflows/android.yml] - Replace the `Run Tests` step with an Android Gradle Action - Pass the `DEVNET_VALIDATOR_URL` as an argument to the `test` command
- Add a checkout action to the android workflow in .github/workflows/android.yml [.github/workflows/android.yml] - Add a checkout action in the android workflow
- Enclose the `DEVNET_VALIDATOR_URL` environment variable in double quotes in the `.github/workflows/android.yml` file. [.github/workflows/android.yml] - Enclose the `DEVNET_VALIDATOR_URL` environment variable in double quotes
Improve compatibility for Android CI tests - Update android.yml to use the correct syntax for the script argument - Ensure the correct URL is used when running tests [.github/workflows/android.yml] - Change the script argument from `test -Ptesting.rpc.defaultUrl="$DEVNET_VALIDATOR_URL"` to `test -Ptesting.rpc.defaultUrl="${DEVNET_VALIDATOR_URL}"`
- Update `test` script to use `DEVNET_VALIDATOR_URL` environment variable - Ensure consistency when running tests on Android [.github/workflows/android.yml] - Change the `test` script to use the `DEVNET_VALIDATOR_URL` environment variable instead of a hard-coded URL
t push - Update `Run Tests` job in `.github/workflows/android.yml` to use `env.DEVNET_VALIDATOR_URL` instead of `DEVNET_VALIDATOR_URL` [.github/workflows/android.yml] - Replace `DEVNET_VALIDATOR_URL` with `env.DEVNET_VALIDATOR_URL` in the `Run Tests` job
- Updated the environment variable in the `Run Tests` job in the `.github/workflows/android.yml` file to `DEVNET_VALIDATOR_URL` [.github/workflows/android.yml] - Changed the environment variable in the `Run Tests` job from `env.DEVNET_VALIDATOR_URL` to `DEVNET_VALIDATOR_URL`
- Fixed syntax error in the android workflow script command [.github/workflows/android.yml] - Fixed syntax error in the android workflow script command
- Update the format of the `DEVNET_VALIDATOR_URL` variable in the `Run Tests` job for Android. [.github/workflows/android.yml] - Change the format of the `DEVNET_VALIDATOR_URL` variable in the `Run Tests` job from `${ DEVNET_VALIDATOR_URL }` to `$(DEVNET_VALIDATOR_URL)`
- Fix the syntax of `DEVNET_VALIDATOR_URL` in the `android.yml` file [.github/workflows/android.yml] - Fix the syntax of `DEVNET_VALIDATOR_URL` in the `android.yml` file
- Update the `DEVNET_VALIDATOR_URL` parameter for Android tests - Refactor the `test` script to pass the parameter correctly [.github/workflows/android.yml] - Change the way the `DEVNET_VALIDATOR_URL` is passed to the `test` script
- Update block and slot numbers in `ApiTests.kt` - Comment out tests in `Methods.kt` - Add import and handle `SerializationException` in `NetworkingRouter.kt` [solana/src/test/java/com/solana/api/ApiTests.kt] - Change the block number for `TestGetBlock` from `164039401` to `196289290` - Change the slot number for `TestGetConfirmedBlock` from `169877548` to `196289670` - Comment out the `TestRequestAirdrop` test - Comment out the `TestGetSignatureStatuses` test [rxSolana/src/test/java/com/solana/rxsolana/api/Methods.kt] - Add import for HotAccount - Change requestAirdrop to use HotAccount public key - Update fixed slot for TestGetConfirmedBlock - Comment out TestGetSignatureStatuses - Comment out TestGetTokenSupply - Update comment for TestGetBlock [solana/src/main/java/com/solana/networking/NetworkingRouter.kt] - Add `kotlinx.serialization.SerializationException` import - Add `kotlin.coroutines.resumeWithException` import - Handle `SerializationException` in `HttpNetworkingRouter`
- Comment out `TestGetConfirmedBlock` and `TestGetBlock` tests in `rxSolana/src/test/java/com/solana/rxsolana/api/Methods.kt` - Change numeric tolerance for test files [rxSolana/src/test/java/com/solana/rxsolana/api/Methods.kt] - Comment out `TestGetConfirmedBlock` and `TestGetBlock` tests - Change numeric tolerance for test files
- Update API calls to use the correct block height - Change `getBlock` and `getConfirmedBlock` API calls from `196289290` and `196289670` to `196291575` [solana/src/test/java/com/solana/api/ApiTests.kt] - Change `getBlock` API call from `196289290` to `196291575` - Change `getConfirmedBlock` API call from `196289670` to `196291575`
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
1.7.20
compileSdkVersion
andtargetSdkVersion
to33
[build.gradle]
1.7.10
to1.7.20
[solana/src/test/java/com/solana/api/ApiTests.kt]URL
andNetwork
compileSdkVersion
from30
to33
targetSdkVersion
from30
to33
Description
Work Completed
API Changes
Testing