Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: improve env variables #403

Merged
merged 2 commits into from
Feb 20, 2025
Merged

feat: improve env variables #403

merged 2 commits into from
Feb 20, 2025

Conversation

andrii-kl
Copy link
Collaborator

  • clean up unused/redundant variables

armyhaylenko
armyhaylenko previously approved these changes Feb 5, 2025
View reviewed changes
Copy link
Contributor

@armyhaylenko armyhaylenko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LBTM

@andrii-kl andrii-kl force-pushed the feat/improve_env_variables branch from 9bf5934 to 41e288f Compare February 13, 2025 10:53
@andrii-kl
feat: improve env variables
fcfadc3 
- clean up unused/redundant variables
@andrii-kl
fix ftm
5d66c6d
@andrii-kl andrii-kl force-pushed the feat/improve_env_variables branch from 41e288f to 5d66c6d Compare February 20, 2025 09:19
StanChe
StanChe approved these changes Feb 20, 2025
View reviewed changes
Copy link
Collaborator

@StanChe StanChe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for cleaning it up

armyhaylenko
armyhaylenko approved these changes Feb 20, 2025
View reviewed changes
Copy link
Contributor

@armyhaylenko armyhaylenko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LBTM

@andrii-kl andrii-kl merged commit 61841e0 into metaplex-foundation:develop Feb 20, 2025
9 of 10 checks passed
@andrii-kl andrii-kl deleted the feat/improve_env_variables branch February 20, 2025 09:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@StanChe StanChe StanChe approved these changes

@armyhaylenko armyhaylenko armyhaylenko approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@andrii-kl @StanChe @armyhaylenko