Skip to content
This repository has been archived by the owner on Mar 31, 2021. It is now read-only.

Make our custom input commands more stable #16

Closed
metas-ts opened this issue Mar 29, 2019 · 0 comments
Closed

Make our custom input commands more stable #16

metas-ts opened this issue Mar 29, 2019 · 0 comments

Comments

@metas-ts
Copy link
Member

Actually, the idea here is to make sure that input commands which cause the frontend to do a PATCH actually wait for the respective PATCH response.

The approach to achieve this is to inspect the PATCH's xhr response body and look for the field name and value that was just typed into the respective field.

We do this as was outlined in this comment: cypress-io/cypress#387 (comment)

metas-ts added a commit that referenced this issue Mar 29, 2019
* push the current status in commands.js;
* @siemiatj the parts i struggle with are at
  * serialletter.js line 48
  * commands.js lines 176 and 481
* also:
  * start using unique alias names
  * prettier improvements
  * additions to index.d.ts
  * additiona to the README.md
  * add license and repository to package.json

#16
metas-ts added a commit that referenced this issue Mar 29, 2019
* serialletter.js once again works on my local machine. Maybe it's because we now wait for unitque alias names (but not sure - don't yet understand this stuff well enough)
#16
metas-ts added a commit that referenced this issue Mar 30, 2019
* fix bug in dataEntry_bpartner_spec.js
* fix bugs in commands.js
* remove builder stuff from bpartner.js
#16
metas-ts added a commit that referenced this issue Apr 1, 2019
* commands.js
  * small cleanup
  * waitForFieldValue has a workaround in order to not fail if the API returns a non-string

#16
metas-ts added a commit that referenced this issue Apr 1, 2019
metas-ts added a commit to metasfresh/metasfresh that referenced this issue Apr 8, 2019
  * [#5024](#5024) REST API for sales invoice payment status
  * [#5095](#5095) Enable set/unset of BPartner narcotics pharma permission
  * [#5118](#5118) Tool to run all migration scripts from developer workspace
  * [#16](metasfresh/metasfresh-e2e-legacy#16) Make our custom input commands more stable
  * [#2214](metasfresh/metasfresh-webui-frontend-legacy#2214) input field value sometimes swallowed
  * [#2237](metasfresh/metasfresh-webui-frontend-legacy#2237) Scrollbars missing in modal overlays
metas-ts added a commit that referenced this issue Apr 8, 2019
* commands.js - add command getFieldValue to get a field's value
* dataEntry_bpartner_spec.js - comment seqNo back in and use it
  * if a seqno already has the value it's supposed to have, then don't write it again and don't expend the frontend to PATCH, because it won't

#16
metas-ts added a commit that referenced this issue Apr 8, 2019
metas-ts added a commit that referenced this issue Apr 9, 2019
* if a field record type already has the value it's supposed to have, then don't write it again and don't expend the frontend to PATCH, because it won't
#16
metas-ts added a commit that referenced this issue Apr 9, 2019
move defunct and not-helping test spec product_set_documentnote.js
#16
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

2 participants