Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor repository and unit tests #29

Closed
wants to merge 7 commits into from
Closed

Conversation

cknoll
Copy link

@cknoll cknoll commented Nov 28, 2021

To make this repository more contribution friendly it should imho be structured in a "standard way", i.e. the top level directory only containing setup.py but not the actual source code. This simplifies the installation in development mode (pip install -e .) and also enables an easier overview of the repo for potential users and contributors.

Also this pr moves the bash based unit tests to a python file using the unittest module from python standard library. This should make it easier to add new tests (which are not necessarily command executions) in the future.

Note that make test still works., see e.g. https://app.circleci.com/pipelines/github/cknoll/pdftitle?branch=develop

@metebalci
Copy link
Owner

Thanks for the ideas here. I am implementing some of these in the next release, 0.12, with more reorganization/refactoring, hence I will not merge this request. The tests I have are actually not unit but end user tests, so I am not sure to change them to unittest.

@metebalci metebalci closed this Oct 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants