Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To make this repository more contribution friendly it should imho be structured in a "standard way", i.e. the top level directory only containing
setup.py
but not the actual source code. This simplifies the installation in development mode (pip install -e .
) and also enables an easier overview of the repo for potential users and contributors.Also this pr moves the bash based unit tests to a python file using the
unittest
module from python standard library. This should make it easier to add new tests (which are not necessarily command executions) in the future.Note that
make test
still works., see e.g. https://app.circleci.com/pipelines/github/cknoll/pdftitle?branch=develop