feat(audit-argument-checks): check default assignments (#776)

meteor · Sep 4, 2020 · 4816e4d · 4816e4d
1 parent 832380a
commit 4816e4d
Show file tree

Hide file tree

Showing 2 changed files with 45 additions and 0 deletions.
diff --git a/lib/rules/audit-argument-checks.js b/lib/rules/audit-argument-checks.js
@@ -91,6 +91,14 @@ module.exports = {
           if (checkedParams.indexOf(param.name) === -1) {
             context.report(param, `"${param.name}" is not checked`);
           }
+        } else if (
+          // check params with default assignments
+          param.type === 'AssignmentPattern' &&
+          param.left.type === 'Identifier'
+        ) {
+          if (checkedParams.indexOf(param.left.name) === -1) {
+            context.report(param.left, `"${param.left.name}" is not checked`);
+          }
         }
       });
     }

diff --git a/tests/lib/rules/audit-argument-checks.js b/tests/lib/rules/audit-argument-checks.js
@@ -71,6 +71,27 @@ ruleTester.run('audit-argument-checks', rule, {
       `,
       parserOptions: { ecmaVersion: 6 },
     },
+    {
+      code: `
+        Meteor.methods({
+            barWellChecked (bar = null) {
+                check(bar, Match.OneOf(Object, null));
+            }
+        })
+      `,
+      parserOptions: { ecmaVersion: 6 },
+    },
+    {
+      code: `
+        Meteor.methods({
+            barWellChecked (foo, bar = null) {
+                check(foo, String);
+                check(bar, Match.OneOf(Object, null));
+            }
+        })
+      `,
+      parserOptions: { ecmaVersion: 6 },
+    },
   ],
 
   invalid: [
@@ -219,5 +240,21 @@ ruleTester.run('audit-argument-checks', rule, {
       ],
       parserOptions: { ecmaVersion: 6 },
     },
+    {
+      code: `
+        Meteor.methods({
+          barBadlyChecked (bar = null) {
+              check(foo, Match.OneOf(Object, null));
+          }
+        })
+      `,
+      errors: [
+        {
+          message: '"bar" is not checked',
+          type: 'Identifier',
+        },
+      ],
+      parserOptions: { ecmaVersion: 6 },
+    },
   ],
 });