test(rules): add more tests to achieve higher code coverage

meteor · Mar 8, 2016 · c460954 · c460954
1 parent 12036a2
commit c460954
Show file tree

Hide file tree

Showing 3 changed files with 11 additions and 1 deletion.
diff --git a/lib/rules/prefer-session-equals.js b/lib/rules/prefer-session-equals.js
@@ -10,7 +10,6 @@ const isSessionGetCallExpression = node => (
   node.type === 'CallExpression' &&
   node.callee.type === 'MemberExpression' &&
   (
-    node.callee.type === 'MemberExpression' &&
     node.callee.object.type === 'Identifier' && node.callee.object.name === 'Session' &&
     (
       (

diff --git a/tests/lib/rules/prefer-session-equals.js b/tests/lib/rules/prefer-session-equals.js
@@ -15,6 +15,10 @@ const ruleTester = new RuleTester()
 
 ruleTester.run('prefer-session-equals', rule, {
   valid: [
+    'var x = 1',
+    'if(x()) {}',
+    'if (true) {}',
+    'if (Session["equals"]("foo", true)) {}',
     'if (Session.equals("foo", true)) {}',
     'if (Session.equals("foo", false)) {}',
     'if (Session.equals("foo", 1)) {}',

diff --git a/tests/lib/rules/template-naming-convention.js b/tests/lib/rules/template-naming-convention.js
@@ -93,6 +93,13 @@ ruleTester.run('template-naming-convention', rule, {
         { message: 'Invalid template naming convention, expected "camel-case"', type: 'MemberExpression' },
       ],
     },
+    {
+      code: 'Template.foo_bar.helpers({})',
+      options: ['pascal-case'],
+      errors: [
+        { message: 'Invalid template naming convention, expected "pascal-case"', type: 'MemberExpression' },
+      ],
+    },
     {
       code: 'Template.fooBar.helpers({})',
       options: ['snake-case'],