Skip to content
This repository has been archived by the owner on Oct 2, 2021. It is now read-only.

Should babel-register be a dev-dependency instead of dependency? #654

Closed
nathan-muir opened this issue May 9, 2018 · 7 comments · Fixed by #656
Closed

Should babel-register be a dev-dependency instead of dependency? #654

nathan-muir opened this issue May 9, 2018 · 7 comments · Fixed by #656

Comments

@nathan-muir
Copy link

nathan-muir commented May 9, 2018 •
edited
Loading

Hi,

Just noticed after updating meteor to 1.7-rc.3, which uses the new babel runtime package (@babel/runtime@^7.0.0-beta.46), that eslint-plugin-meteor was still depending on babel-register / babel-runtime @ 6.26

Compared with other plugins, I'm guessing that babel-register shouldn't be under dependencies, but belongs under devDependencies instead.

eg. https://github.com/3stack-software/eslint-plugin-meteor/commit/dd53fe1bbe9b14e10adfcaafe39af0d36e51c8f4
@dferber90
Copy link
Contributor

Thanks for reporting this! Indeed, we're using babel-register for tests only, so it can go to devDependencies.

I'm not sure which node version Meteor uses these days and which versions we still need to support. Given that the lowest supported node version is advanced enough we might be able to get rid of babel completely in the future.

@dferber90 dferber90 mentioned this issue May 9, 2018
Merged
@dferber90
Copy link
Contributor

🎉 This issue has been resolved in version 4.2.2 🎉

The release is available on:

Your semantic-release bot 📦🚀

@dferber90
Copy link
Contributor

Can you try installing eslint-plugin-meteor@next and let me know whether things still work for you? If so, I'll publish this as the latest version.

@nathan-muir
Copy link
Author

Ah, no. There's still a bit of code dependent on the babel-runtime, as you're using "transform-runtime" in .babelrc..

@dferber90 dferber90 reopened this May 9, 2018
dferber90 added a commit that referenced this issue May 9, 2018
@dferber90
refactor: spring cleanup
59673dd 
Remove babel and convert code to use CommonJS format.
Convert rules to updated format (https://eslint.org/docs/developer-guide/working-with-rules).

closes #654
@dferber90 dferber90 mentioned this issue May 9, 2018
Merged
dferber90 added a commit that referenced this issue May 9, 2018
@dferber90
refactor: spring cleanup
7efefe1 
Remove babel and convert code to use CommonJS format.
Convert rules to updated format (https://eslint.org/docs/developer-guide/working-with-rules).

BREAKING CHANGE: Changes exported, recommended eslint config (`extends: ["plugin:meteor/recommended"]`) to enable ecmaVersion 6, sourceType module and jsx for the ESLint parser.

closes #654
dferber90 added a commit that referenced this issue May 9, 2018
@dferber90
refactor: spring cleanup
a5ed442 
Remove babel and convert code to use CommonJS format.
Convert rules to updated format (https://eslint.org/docs/developer-guide/working-with-rules).

BREAKING CHANGE: Changes exported, recommended eslint config (`extends: ["plugin:meteor/recommended"]`) to enable ecmaVersion 6, sourceType module and jsx for the ESLint parser.

closes #654
@dferber90
Copy link
Contributor

🎉 This issue has been resolved in version 5.0.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

@dferber90
Copy link
Contributor

I completely removed babel as a dependency in 5.0.0. Let me know how that works for you. I went ahead and tried it myself and all seemed to work nicely.

Note: eslint-plugin-meteor now needs at least node@6, which is the current minimal LTS version.

@nathan-muir
Copy link
Author

Works great @dferber90, Cheers!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

refactor: spring cleanup meteor/eslint-plugin-meteor
2 participants
@dferber90 @nathan-muir