Adding a plugin to calculate the virtual temperature #2058
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #2058 +/- ##
==========================================
- Coverage 98.39% 98.38% -0.01%
==========================================
Files 124 134 +10
Lines 12212 13083 +871
==========================================
+ Hits 12016 12872 +856
- Misses 196 211 +15 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
I've looked through the changes and I'm generally happy with them:
- The virtual temperature plugin looks like it does what it's supposed to
- The unit tests that have written look sensible and all run fine
- The PR is failing due to the PR standards - I think it's just something to do with adding yourself as a contributor. I think it's because in the email address you are [email protected] but you have put your name as Philip it doesn't like this. It might be worth changing that and see if it then passes that test?
- I've left a couple of comments about your comments but they are very minor.
improver/virtual_temperature.py
Outdated
|
|
||
|
|
||
| class VirtualTemperature(BasePlugin): | ||
| """Calculates the virtual temperature from temperature and .""" |
There was a problem hiding this comment.
Do you want to write humidity mixing ratio here too?
There was a problem hiding this comment.
I did, but I have now changed this string to """Plugin class to handle virtual temperature calculations.""" to better answer your second comment.
| @staticmethod | ||
| def get_virtual_temperature(temperature: Cube, humidity_mixing_ratio: Cube) -> Cube: | ||
| """ | ||
| Calculate the virtual temperature from temperature and humidity mixing ratio. |
There was a problem hiding this comment.
Do you need to repeat yourself here?
There was a problem hiding this comment.
You're right it's a little repetitive. I have changed the class docstring.
|
The cause of the failing tests was a poorly set up git config. Rather than confusing this PR with further commits and rewriting the history to the new configuration I will close this PR and open a new one. |
Address: https://metoffice.atlassian.net/browse/EPPT-1965
This PR adds a plugin to calculate the virtual temperature based on the air temperature and humidity mixing ratio.
No CLI added due to the move to the DAG runner.
Testing:
CLA