Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

option for output path #20

Merged
merged 5 commits into from
Feb 15, 2024
Merged

option for output path #20

merged 5 commits into from
Feb 15, 2024

Conversation

ainozaki
Copy link
Contributor

@ainozaki ainozaki commented Feb 5, 2024

Add option to specify output path

@ainozaki ainozaki requested a review from saza-ku February 5, 2024 10:24
Copy link
Contributor

@saza-ku saza-ku left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool!

It would be better to specify the enter path of the output file, instead of the directory of it.

And we would update the docs.

@ainozaki
Copy link
Contributor Author

Thank you!
I've modified it to specify a file path. The default value remains the same (output will still be directed to "./wasm.o" as before.)

Copy link
Contributor

@saza-ku saza-ku left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@ainozaki ainozaki merged commit 5280faf into main Feb 15, 2024
2 checks passed
@ainozaki ainozaki mentioned this pull request Feb 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants