Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updates GitHub workflow for documentation build #61

Merged
merged 1 commit into from
Jan 13, 2024

Conversation

froschdesign
Copy link
Member

No description provided.

@froschdesign froschdesign added the Bug Something isn't working label Jan 13, 2024
@Ocramius
Copy link
Member

Change looks harmless, but I don't understand it 🤔

@froschdesign
Copy link
Member Author

The DOCS_DEPLOY_KEY is the legacy key and must be replaced:

# check values
remote_repo=""
if [ -n "${DEPLOY_TOKEN}" ]; then
    remote_repo_setup remote_repo "${DEPLOY_TOKEN}"
else
    if [ -n "${DOCS_DEPLOY_KEY}" ]; then
        remote_repo_setup_legacy remote_repo "${DOCS_DEPLOY_KEY}"
    else
        print_error "Neither DEPLOY_TOKEN nor DOCS_DEPLOY_KEY found; please provide one or the other in your workflow env"
        kill -s KILL $TOP_PID
    fi
fi

https://github.com/laminas/documentation-theme/blob/c9c95a899460735dc06ccff05ec47d1c4f95e8ba/github-actions/docs/entrypoint.sh#L64-L75

@Ocramius
Copy link
Member

@froschdesign thanks! As a note for future changes, try putting this sort of reasoning in commits, when not too cumbersome 😁

@Ocramius Ocramius self-assigned this Jan 13, 2024
@Ocramius Ocramius added this to the 1.11.1 milestone Jan 13, 2024
@Ocramius Ocramius merged commit 399d1b6 into mezzio:1.11.x Jan 13, 2024
11 checks passed
@froschdesign froschdesign deleted the hotfix/workflow/docs-build branch January 13, 2024 12:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Something isn't working Documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants