Treat PSR-7 request conversions as route failures #13
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Required as of Composer 2.2 series Signed-off-by: Matthew Weier O'Phinney <[email protected]>
…-http
This patch adds a try/catch block within the `LaminasRouter::match()` method around the conversion of the PSR-7 request to a laminas-http request.
It catches laminas-http `InvalidArgumentException`s, and checks for a previous exception matching a laminas-http `InvalidUriPartException`.
When detected, it returns a `RouteResult` indicating a routing failure; otherwise, it rethrows the exception.
The patch is intended to fix scenarios where the Host header is invalid (e.g. `${ip}`), leading to creation of an invalid URI.
Fixes mezzio#12
Signed-off-by: Matthew Weier O'Phinney <[email protected]>
Signed-off-by: Matthew Weier O'Phinney <[email protected]>
Tested locally, and update operations, both with and without `--prefer-lowest`, work without errors now. Signed-off-by: Matthew Weier O'Phinney <[email protected]>
|
@weierophinney perhaps to be released as bugfix? |
It's a slight behavior change; previously, you'd get an uncaught exception that would bubble up to the error handler, but now you'll get a route failure. I think it makes sense to call it out in a minor. |
|
Thanks @weierophinney! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch adds a try/catch block within the
LaminasRouter::match()method around the conversion of the PSR-7 request to a laminas-http request. It catches laminas-httpInvalidArgumentExceptions, and checks for a previous exception matching a laminas-httpInvalidUriPartException. When detected, it returns aRouteResultindicating a routing failure; otherwise, it rethrows the exception.The patch is intended to fix scenarios where the Host header is invalid (e.g.
${ip}), leading to creation of an invalid URI.Fixes #12