-
-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add compatibility with PHP 8.1 #9
Conversation
Signed-off-by: Pascal Heidmann <[email protected]>
Signed-off-by: Pascal Heidmann <[email protected]>
Signed-off-by: Pascal Heidmann <[email protected]>
…ompatibility Signed-off-by: Pascal Heidmann <[email protected]>
Signed-off-by: Pascal Heidmann <[email protected]>
0a8fac2
to
0293eca
Compare
@@ -0,0 +1,5 @@ | |||
{ | |||
"ignore_php_platform_requirements": { | |||
"8.1": true |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this still needed with the new dependency releases?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's keep it for now
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The files added to .gitignore also need to be removed from this commit (.phpcs-cache and .phpunit.result.cache).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks @pascalheidmann
Description
This PR updates some dependencies to be compatible with PHP 8.1. Also adds minor improvements to tests like type hints & return types.
Notice
It uses a reference to laminas/laminas-i18n#62 for laminas-i18n which should be merged and replaced with a real release before this PR can be merged.