Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add compatibility with PHP 8.1 #9

Merged
merged 5 commits into from
Dec 6, 2021
Merged

Conversation

pascalheidmann
Copy link

Q A
Documentation no
Bugfix no
BC Break no
New Feature no
RFC no
QA yes

Description

This PR updates some dependencies to be compatible with PHP 8.1. Also adds minor improvements to tests like type hints & return types.

Notice

It uses a reference to laminas/laminas-i18n#62 for laminas-i18n which should be merged and replaced with a real release before this PR can be merged.

@pascalheidmann pascalheidmann marked this pull request as draft November 21, 2021 22:19
@froschdesign froschdesign mentioned this pull request Nov 24, 2021
@froschdesign froschdesign added the Enhancement New feature or request label Nov 26, 2021
@froschdesign froschdesign added this to the 3.2.0 milestone Nov 26, 2021
@pascalheidmann pascalheidmann marked this pull request as ready for review December 1, 2021 22:45
@@ -0,0 +1,5 @@
{
"ignore_php_platform_requirements": {
"8.1": true
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this still needed with the new dependency releases?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's keep it for now

Copy link
Member

@internalsystemerror internalsystemerror left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The files added to .gitignore also need to be removed from this commit (.phpcs-cache and .phpunit.result.cache).

@Ocramius Ocramius self-assigned this Dec 6, 2021
Copy link
Member

@Ocramius Ocramius left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks @pascalheidmann

@Ocramius Ocramius merged commit 1731e2e into mezzio:3.2.x Dec 6, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants