1.4.x code updates #15
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
pine3ree
commented
Oct 7, 2020
pine3ree
commented
- Remove unnecessary checks since dflydev/fig-cookies version requirement is now >= 2 where SameSIte is supported
- Use new and more descriptive phpunit assertion method as was done here
- minor code update for unused var
Signed-off-by: pine3ree <[email protected]>
Signed-off-by: pine3ree <[email protected]>
|
P.S. Not sure why travis builds here seem stuck (it happened on mezzio-session-ext too). They seem to run fine in my account: https://travis-ci.org/github/pine3ree/mezzio-session |
I noticed it yesterday, too, when doing the PHP 8 and Psalm PRs. It looks like GitHub is somehow triggering multiple identical builds on Travis. If you look, we have a successful build present, in addition to the stuck one. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.