Update Session parameter docs for SessionPersistenceInterface
#33
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Until 2.0 is released, persistence implementations generally need to know what the session id is with `$session->getId()` inside their `persistSession` implementation. This changes the expected parameter to an intersection of `SessionInterface&SessionIdentifierAwareInterface` Signed-off-by: George Steel <[email protected]>
|
It's a breakage, but a valid one. It will cause a cascade of type-checking failures, I suppose 🤔 |
It should fix more than it breaks shouldn't it?, certainly in mezzio-session-* stuff because $session->getId() is missing from SessionInterface, but widely used. I didn't find any implementations that don't already implement both interfaces… |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Until 2.0 is released, persistence implementations generally need to know what the session id is with
$session->getId()inside theirpersistSessionimplementation. This changes the expected parameter to an intersection ofSessionInterface&SessionIdentifierAwareInterface