-
-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Removed SessionIdentifierAwareInterface
#71
Conversation
Signed-off-by: alexmerlin <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code changes look 👍 - Just the redirects need updating
Signed-off-by: alexmerlin <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry @alexmerlin - I've just been checking the implementations due to the removed test testGetIdReturnsEmptyStringIfNoIdentifierProvidedToConstructor
, and the session id is expected to be ''|non-empty-string
. This is used to signal to persistence implementations that the session needs to be regenerated - My fault. It might have been clearer for the id to be typed as null|non-empty-string
but it's not worth changing this for all the implementations.
I should have checked this out properly before opening my mouth! So the addition of non-empty-string
needs to be reverted.
For future reference, the @psalm-
prefix is generally unnecessary. Most IDEs along with Psalm and PHPStan understand non-empty-string
and most other annotations. Notable exceptions to this rule are @psalm-type
and @psalm-import-type
Signed-off-by: alexmerlin <[email protected]>
…or test. Signed-off-by: alexmerlin <[email protected]>
Signed-off-by: alexmerlin <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @alexmerlin 👍
@alexmerlin @gsteel |
Description
As requested in #59 this commit:
SessionIdentifierAwareInterface
'sgetId()
method toSessionInterface
SessionIdentifierAwareInterface
Also, adds
v2
documentation.