Import #2
Draft
Import #2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Matthew Setter <[email protected]>
This test is to help ensure that StaticPagesHandler returns the correct HtmlResponse object if the requested route is configured correctly. Specifically, the route needs to have its name parameter set and that parameter needs to start with 'static.'. Signed-off-by: Matthew Setter <[email protected]>
This test ensures that the code can handle a requested route which doesn't have a name set. Signed-off-by: Matthew Setter <[email protected]>
This change refactors the code for retrieving the route's name into a standalone function. My intent here is to make it easier to maintain and test, as I have a number of ideas for how it can be improved in future iterations, and this refactoring makes it easier to do than an inline code block. Signed-off-by: Matthew Setter <[email protected]>
Signed-off-by: Matthew Setter <[email protected]>
I don't expect them to be extended, so let's make it impossible to do so. Signed-off-by: Matthew Setter <[email protected]>
This updates the package's name to be what it should be, removes unnecessary requirements, and sort the various config lists so that they're quickly scannable. Signed-off-by: Matthew Setter <[email protected]>
Signed-off-by: Matthew Setter <[email protected]>
From what I've read on https://github.com/zendframework/zend-component-installer, I need to make use of the extra/zf/config-provider key in composer.json so that the module's ConfigProvider class will be made available to the application that it's used inside of. Signed-off-by: Matthew Setter <[email protected]>
The templates directory that was originally bundled with the module isn't necessary and would potentially attempt to force someone to create template files in an unnatural way. Therefore, they're being removed, along with the ConfigProvider reference to them. Signed-off-by: Matthew Setter <[email protected]>
Signed-off-by: Matthew Setter <[email protected]>
Signed-off-by: Matthew Setter <[email protected]>
This change adds the code of conduct, contributing guide, support guide, issue and PR templates common to Zend Framework projects. Signed-off-by: Matthew Setter <[email protected]>
Specifically, this change adds phpstan, test coverage, and the other composer.json attributes common to Zend Framework projects. It also adds Zend Coding Standard as a dev dependency so that php-cs can be run. Signed-off-by: Matthew Setter <[email protected]>
Signed-off-by: Matthew Setter <[email protected]>
Signed-off-by: Matthew Setter <[email protected]>
Signed-off-by: Matthew Setter <[email protected]>
Signed-off-by: Matthew Setter <[email protected]>
Signed-off-by: Matthew Setter <[email protected]>
This fixes #5. Thanks @froschdesign! Signed-off-by: Matthew Setter <[email protected]>
I received feedback from @xtreamwayz that it's likely better to remove the modular structure of the src directory, as it's a library, and not necessary to have such a nested approach. It made sense to me, so I'm implementing it. Signed-off-by: Matthew Setter <[email protected]>
This package hasn't been updated in a while, so this is a more than modest size change. It updates all of the package dependencies to use the most recent versions, also accommodating name changes (Zend Expressive -> Laminas). It also updates a lot of the code to reflect more recent changes in PHP 7.4. Signed-off-by: Matthew Setter <[email protected]>
Removed unnecessary docblock comments and updated the Composer configuration for loading the package's ConfigProvider. Signed-off-by: Matthew Setter <[email protected]>
Add a GitHub Action workflow for testing the code Signed-off-by: Matthew Setter <[email protected]>
This change reflects the recents changes to the laminas packages, which I want this package to follow. Signed-off-by: Matthew Setter <[email protected]>
This change adds Psalm as a Composer development dependency, adds the required configuration files, taken from one of the laminas packages (and slightly modified), and adds a Composer script to automate running static analysis. Signed-off-by: Matthew Setter <[email protected]>
Signed-off-by: Matthew Setter <[email protected]>
Signed-off-by: Matthew Setter <[email protected]>
I'm not sure how the changes were reverted, but this change re-inserts them. Signed-off-by: Matthew Setter <[email protected]>
From what I can see, at least when compared to other laminas and Mezzio packages, the previous namespace was unnecessarily convoluted. This change simplifies it, and reorganises the files and directories to match it. The change also cleans up the files, removing unnecessary methods, and class member variables. Signed-off-by: Matthew Setter <[email protected]>
This change updates the lock file, as it's currently in conflict. Signed-off-by: Matthew Setter <[email protected]>
This change ensures that the PHPUnit configuration file uses the correct configuration, without deprecated elements, and matches (where possible) the other PHPUnit configuration files used by the laminas and mezzio projects. Signed-off-by: Matthew Setter <[email protected]>
After looking at several other Mezzio projects, these files are not used. Given that, this commit removes them from this project. Signed-off-by: Matthew Setter <[email protected]>
This change adds laminas-ci.json which other Mezzio projects use. Signed-off-by: Matthew Setter <[email protected]>
This change updates the documentation so that it follows the format of other Mezzio projects. Signed-off-by: Matthew Setter <[email protected]>
There was an error in the build because the getting started guide contained two level one headers. This change splits the file into two separate ones to correct this issue. Signed-off-by: Matthew Setter <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This is the initial import of the existing project into the new Mezzio org version.