Merge pull request #102 from mfontanini/deny-unknown-yaml-fields

Deny unknown fields in yaml models
mfontanini · Dec 22, 2023 · 2f1c2ac · 2f1c2ac
2 parents 6a83995 + b5d38b1
commit 2f1c2ac
Show file tree

Hide file tree

Showing 4 changed files with 10 additions and 0 deletions.
diff --git a/src/builder.rs b/src/builder.rs
@@ -1597,4 +1597,11 @@ mod test {
             assert_eq!(&line.prefix, &format!("{line_number} "));
         }
     }
+
+    #[test]
+    fn extra_fields_in_metadata() {
+        let element = MarkdownElement::FrontMatter("nope: 42".into());
+        let result = try_build_presentation(vec![element]);
+        assert!(result.is_err());
+    }
 }
diff --git a/src/custom.rs b/src/custom.rs
@@ -2,6 +2,7 @@ use serde::Deserialize;
 use std::{fs, io, path::Path};
 
 #[derive(Clone, Debug, Default, Deserialize)]
+#[serde(deny_unknown_fields)]
 pub struct Config {
     #[serde(default)]
     pub defaults: DefaultsConfig,

diff --git a/src/presentation.rs b/src/presentation.rs
@@ -310,6 +310,7 @@ pub(crate) trait ChunkMutator: Debug {
 
 /// The metadata for a presentation.
 #[derive(Clone, Debug, Deserialize)]
+#[serde(deny_unknown_fields)]
 pub(crate) struct PresentationMetadata {
     /// The presentation title.
     pub(crate) title: Option<String>,

diff --git a/src/theme.rs b/src/theme.rs
@@ -55,6 +55,7 @@ impl PresentationThemeSet {
 
 /// A presentation theme.
 #[derive(Default, Clone, Debug, Deserialize, Serialize)]
+#[serde(deny_unknown_fields)]
 pub struct PresentationTheme {
     /// The style for a slide's title.
     #[serde(default)]