Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support images to some extent on Windows #120

Merged
merged 3 commits into from
Jan 9, 2024
Merged

Conversation

mfontanini
Copy link
Owner

This PR attempts to add some support for images on Windows. Specifically:

  • Getting the terminal size in pixels fails in that platform so instead we default to a 16 pixel font size and let you specify some other via the config file. This ain't great but it gets the job done.
  • WezTerm seems to completely break if you hide the cursor and then display images on Windows (works fine in Linux!). So in that specific combo we don't hide the cursor. This is done only in that scenario as not hiding the cursor is suboptimal as you can sometimes see it moving, especially when printing images. Unfortunately without this images are completely broken there so this is better than nothing.

There's still more work to be done here. e.g. this doesn't work well in the git bash for windows terminal (whatever that is) but at least it seems to work on wezterm.

Relates to #13

@mfontanini mfontanini merged commit ceeac45 into master Jan 9, 2024
5 checks passed
@mfontanini mfontanini deleted the windows-images branch January 9, 2024 03:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant