Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Detect image protocol instead of relying on viuer #160

Merged
merged 1 commit into from
Jan 22, 2024

Conversation

mfontanini
Copy link
Owner

This PR:

  • Detects the terminal emulator we're using.
  • Figures out which image protocol to use.
  • Turns the --image-protocol cli arg from a hint into a respected value, at least for the kitty and iterm protocols.

The main motivation for this is that viuer has limited detection, e.g. it doesn't know wezterm supports the kitty protocol so now, while it still uses the iterm one by default, you can pass in --image-protocol kitty-local when using wezterm and it will be respected. This is also some ground work to be able to work on #72 next.

@mfontanini mfontanini merged commit 2767a44 into master Jan 22, 2024
5 checks passed
@mfontanini mfontanini deleted the detect-image-protocol branch January 22, 2024 23:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant