Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve sixel support #169

Merged
merged 3 commits into from
Jan 24, 2024
Merged

Improve sixel support #169

merged 3 commits into from
Jan 24, 2024

Conversation

mfontanini
Copy link
Owner

This stops using viuer to render images using sixel and instead does something very similar but within this codebase. The reason for this is when testing sixel support in wezterm I would get tiny images, which is because the font size is hardcoded in viuer. Here instead we pull it from the config file so you can configure it to be whatever works for your environment.

This also allows forcing the use of sixel. Because viuer always checks if a mode is supported before using it, there's no way to override that decision and say "use sixel!". With this change, if you pass in --image-protocol sixel it will use it (which means if you don't support it it will break).

@mfontanini mfontanini merged commit f926908 into master Jan 24, 2024
5 checks passed
@mfontanini mfontanini deleted the better-sixel branch January 24, 2024 21:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant