Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: hide footer on intro slide by default #339

Closed
wants to merge 1 commit into from

Conversation

calebdw
Copy link
Contributor

@calebdw calebdw commented Aug 15, 2024

Hello!

This PR hides the footer on the intro slide by default which is fairly common in presentations and I think it would make a great default.

If you think differently then feel free to close :).

Note: maybe there's a better way of making this the default in the code without having to add it to all the themes?

Thanks!

@mfontanini
Copy link
Owner

I don't know about this one. I think this makes sense when using a template footer as it will likely have overlapping information with what the intro slide shows. However, all built-in themes default to the progress-bar style footer. For that one, I think not showing the footer in the intro slide actually looks weird and it also doesn't have the issue of overlapping information with the intro slide like the template one does.

@calebdw calebdw closed this Aug 18, 2024
@calebdw calebdw deleted the hide_footer branch August 18, 2024 19:49
mfontanini added a commit that referenced this pull request Aug 21, 2024
This makes the footer in built in themes be a template with
`{current_slide} / {total_slides}` in the right. The progress bar was
"cool" but it's not very professional so I don't think it should be the
default.

Relates to #339 #357
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants